Simplify settings package and a few more classes using DI #6778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Coverage Report 1Affected Products
Test Logs |
Test Results 38 files - 994 38 suites - 994 55s ⏱️ - 33m 27s Results for commit 617945b. ± Comparison against base commit 76990d9. This pull request removes 5768 tests.♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
themiswang
approved these changes
Mar 17, 2025
tejasd
requested changes
Mar 17, 2025
tejasd
approved these changes
Mar 19, 2025
tejasd
pushed a commit
that referenced
this pull request
Apr 1, 2025
Simplify settings package and a few more classes using DI. The biggest example is `SessionsSettings`, which used to have multiple secondary constructors. This change lets us avoid plumbing dependencies like `DataStore<>` through multiple classes. Moved DataStore construction into provides, which will be needed for `MultiProcessDataStoreFactory`. Also cleaned up tests a bit. We shouldn't use Dagger in the unit tests on Android. Once we remove the bound service, it will be easy to remove DI from the unit tests. Instead, unit tests will just call the constructors directly and pass in real or fake instances.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify settings package and a few more classes using DI.
The biggest example is
SessionsSettings, which used to have multiple secondary constructors. Thischange lets us avoid plumbing dependencies like
DataStore<>through multiple classes.Moved DataStore construction into provides, which will be needed for
MultiProcessDataStoreFactory.Also cleaned up tests a bit. We shouldn't use Dagger in the unit tests on Android. Once we remove
the bound service, it will be easy to remove DI from the unit tests. Instead, unit tests will just
call the constructors directly and pass in real or fake instances.